Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 Creating new domain causes deprecated function warning #47

Open
yorkshire-pudding opened this issue Nov 12, 2024 · 0 comments · May be fixed by #48
Open

PHP 8.1 Creating new domain causes deprecated function warning #47

yorkshire-pudding opened this issue Nov 12, 2024 · 0 comments · May be fixed by #48
Assignees
@yorkshire-pudding
Labels
pr - needs code review The Pull Request needs to be code-reviewed pr - needs testing The Pull Request still needs to be tested status - has pull request This issue has a Pull Request type - bug report Something isn't working

Comments

@yorkshire-pudding
Copy link
Collaborator

yorkshire-pudding commented Nov 12, 2024 •
edited
Loading

Steps to reproduce

  1. Enable display of all error and warning messages.
  2. Have PHP 8.1 or higher
  3. Create new domain record

Expected result
Domain is saved with no error messages

Actual result
Domain is saved but error message displays:

Deprecated function: strcmp(): Passing null to parameter #2 ($string2) of type string is deprecated in domain_form_validate() (line 617 of /app/docroot/modules/domain/domain.admin.inc).
@yorkshire-pudding yorkshire-pudding added the type - bug report Something isn't working label Nov 12, 2024
@yorkshire-pudding yorkshire-pudding self-assigned this Nov 12, 2024
yorkshire-pudding added a commit to yorkshire-pudding/domain that referenced this issue Nov 12, 2024
@yorkshire-pudding
Issue backdrop-contrib#47: Fix deprecation warning
b19c479
@yorkshire-pudding yorkshire-pudding linked a pull request Nov 12, 2024 that will close this issue
Open
@izmeez izmeez added pr - needs code review The Pull Request needs to be code-reviewed pr - needs testing The Pull Request still needs to be tested status - has pull request This issue has a Pull Request labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorkshire-pudding yorkshire-pudding

Labels
pr - needs code review The Pull Request needs to be code-reviewed pr - needs testing The Pull Request still needs to be tested status - has pull request This issue has a Pull Request type - bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #47: Fix deprecation warning yorkshire-pudding/domain
2 participants
@izmeez @yorkshire-pudding