Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-insights: Move TechInsightCheck to @backstage-community/plugin-tech-insights-common #1527

Open
2 tasks done
mostafah opened this issue Oct 15, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@mostafah
Copy link

Plugin Name

tech-insights

🔖 Feature description

Actually, it is not a feature, but I could not find a more fitting plugin-related option when openning a new issue.

The type TechInsightCheck is exported from @backstage-community/plugin-tech-insights-node. But it has nothing that is exclusive to the node envionment. Moving it to @backstage-community/plugin-tech-insights-common makes it accessible in more places.

🎤 Context

Just to give a use case as an example, in our Backstage instance we have a -common isomorphic plugin for defining types and common values about our custom tech insights checks. Right now we have to copy TechInsightCheck to it so that we can extend it with our CustomTechInsightCheck type. This type includes extra information that can help UI (like grouping information, a short name for table views, …) so frontend application importes and uses CutomTechInsightCheck. That’s why this type should be in a -common package and that’s also the reason it is not possible to import TechInsightCheck from its current package.

✌️ Possible Implementation

I would be happy to create a PR if the change makes sense to you.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@mostafah mostafah added the enhancement New feature or request label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant