Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic usage of mutable within fd_t #17

Open
lethalbit opened this issue Jun 23, 2022 · 1 comment
Open

Problematic usage of mutable within fd_t #17

lethalbit opened this issue Jun 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lethalbit
Copy link
Member

Within the fd_t type both _length and eof are marked mutable and then used in const expressions which change their value.

This should be corrected by removing the mutable marking from them and then also removing the const from the methods which assign to them.

I've not checked to see if this is also a problem in other parts but a through check would be ideal.

@lethalbit lethalbit added the enhancement New feature or request label Jun 23, 2022
@dragonmux dragonmux self-assigned this Jan 20, 2023
@dragonmux
Copy link
Member

We should probably try and do this review and cleanup sooner than later to ensure Mangrove's bootstrap compiler isn't going to wind up with subtle correctness issues because of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants