Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsDom peerDependency precludes two major versions #31

Closed
jjoekoullas opened this issue Jun 17, 2019 · 2 comments
Closed

jsDom peerDependency precludes two major versions #31

jjoekoullas opened this issue Jun 17, 2019 · 2 comments

Comments

@jjoekoullas
Copy link

Noticed this when jsdom was not detecting canvas was installed alongside it. Updating to jsdom to 15 fixed it, however this package only lists up to 13 as a valid peer dependency.

I've updated the peer dependencies to 15 for my own use, but due #30 I'm not able to run tests.

@badeball
Copy link
Owner

Support for v14 and v15 has been added with v7.1.1. Thanks for letting me know.

@badeball
Copy link
Owner

I've "watched" the JSDOM repository for new releases for some time now, but never actually received any notifications. I've registered that [1-2] even though publishing tags is listed as a "release" in the interface, it's not considered notification-worthy unless it is accompanied by a description (lol, what kind of a joke is this). I've subscribed to newreleases.io, which hopefully will let me add new support in a more timely manner.

[1] isaacs/github#410
[2] https://github.community/t5/How-to-use-Git-and-GitHub/Not-getting-release-notification-despite-quot-Watching-releases/td-p/19665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants