Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine_iac): support terraform and evaluate all rules #242

Merged
merged 8 commits into from
Nov 12, 2024
Merged

feat(engine_iac): support terraform and evaluate all rules #242

merged 8 commits into from
Nov 12, 2024

Conversation

jcamilomolinar
Copy link
Collaborator

Description

handling a new framework (terraform) for engine iac with the checkov tool, also set to evaluate all rules in case there are no rules specified in the config tool

Checklist:

  • The pull request is complete according to the guide of contributing of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Gaviria9601
Gaviria9601 reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Gaviria9601 Gaviria9601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review the comments

tools/devsecops_engine_tools/version.py Outdated Show resolved Hide resolved
.../engine_sast/engine_iac/src/infrastructure/driven_adapters/checkov/checkov_deserealizator.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
76.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Gaviria9601
Gaviria9601 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Gaviria9601 Gaviria9601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcamilomolinar jcamilomolinar merged commit 02751fc into trunk Nov 12, 2024
5 checks passed
@app-toolkit-opensource-innersource APP Toolkit OpenSource - InnerSource
Copy link
Contributor

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@app-toolkit-opensource-innersource APP Toolkit OpenSource - InnerSource
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Gaviria9601 Gaviria9601 deleted the feature/support_terraform branch November 14, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaviria9601 Gaviria9601 Gaviria9601 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcamilomolinar @Gaviria9601