Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in modes/pairwise_multi_pol.py #634

Open
platonfloria opened this issue May 8, 2024 · 2 comments
Open

Bug in modes/pairwise_multi_pol.py #634

platonfloria opened this issue May 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@platonfloria
Copy link
Collaborator

Bug Description

With optimizer decoupling it was uncovered that [T.ETH, T.WETH] is in fact
[self.ConfigObj.WRAPPED_GAS_TOKEN_ADDRESS, self.ConfigObj.WRAPPED_GAS_TOKEN_ADDRESS]

Severity (High/Medium/Low)

High

Steps to Reproduce

Replace [self.ConfigObj.WRAPPED_GAS_TOKEN_ADDRESS, self.ConfigObj.WRAPPED_GAS_TOKEN_ADDRESS]
with [self.ConfigObj.NATIVE_GAS_TOKEN_ADDRESS, self.ConfigObj.WRAPPED_GAS_TOKEN_ADDRESS]
in modes/pairwise_multi_pol.py

Expected Behavior

ETH and WETH should be treated deifferently

Actual Behavior

T.ETH and T.WETH are treated differently, even though they have the same address

Impact Analysis (to be filled by contributors)

  • Automated Tests: Are there existing tests covering this? Do we need new tests? - Yes
  • Risks: Potential areas affected by this bug and its probable fix - Opportunities are calculated incorrectly
  • Performance: Is this bug affecting performance? - Unknown
  • Monitoring: Does this affect any current monitoring? Any new alerts needed? - No
  • Logging: Any changes required in logging? - No
  • Documentation: Updates needed in documentation? - No
@platonfloria platonfloria added the bug Something isn't working label May 8, 2024
@sklbancor
Copy link
Collaborator

Note that T will be removed from the Optimizer in an upcoming PR
https://github.com/bancorprotocol/arb-optimizer/pull/24

@barakman
Copy link
Collaborator

barakman commented May 8, 2024

The problem described here was introduced in PR #633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants