Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an easy way to do quick code edits using github without breaking on prettier #594

Open
zavelevsky opened this issue Aug 3, 2022 · 0 comments
Labels
Technical Technical enhancement or debt

Comments

@zavelevsky
Copy link
Collaborator

Use case: Asaf/Yaniv want to change texts and create a PR - by editing directly in github.
However, build fails because line length changes lead to prettier issues.

One option is to have them edit using github.dev - which is a lightweight VSCode version, but we need to find a way that it will apply our settings. Maybe using editorconfig? Or some script to run and apply styling fixes?

@zavelevsky zavelevsky added the Technical Technical enhancement or debt label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Technical enhancement or debt
Projects
None yet
Development

No branches or pull requests

1 participant