Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit group id management #593

Open
sripwoud opened this issue Oct 30, 2024 · 1 comment
Open

revisit group id management #593

sripwoud opened this issue Oct 30, 2024 · 1 comment
Labels
feature 🚀 This is enhancing something existing or creating something new

Comments

@sripwoud
Copy link

sripwoud commented Oct 30, 2024

Is your feature request related to a problem? Please describe.
The way the group id is generated (depends on the name) prevents allowing for updating the name (see #589).

Describe the solution you'd like
Why not stop generating groupIds on the application layer and let the db generate them instead (modify the groups table schema)?
A common practice is e.g to use an identity column. This way the unicity of the group id would be enforced at db level and you wouldn't have to worry about it. Especially it would break the dependency between name and groupId so we could allow updating the name

This is a breaking change (think about how to handle group id generated before/after the change)

@sripwoud sripwoud added the feature 🚀 This is enhancing something existing or creating something new label Oct 30, 2024
@vplasencia
Copy link
Member

Hey @sripwoud! Thanks for creating this issue. Yes, agree, the group ids should be automatically generated at db level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new
Projects
None yet
Development

No branches or pull requests

2 participants