Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title of the webpage #22

Closed
wenbinyu-PU opened this issue Oct 16, 2024 · 4 comments
Closed

title of the webpage #22

wenbinyu-PU opened this issue Oct 16, 2024 · 4 comments

Comments

@wenbinyu-PU
Copy link
Collaborator

If I want to change the title from SwiftComp to Composites AI, where should I make changes? index.html <title>Composites AI</title> or other places, if this file is automatically generated?

image

@banghuazhao
Copy link
Owner

banghuazhao commented Oct 16, 2024

Right, the place is index.html <title>Composites AI</title>. In double-checked with chatGPT, it is automatically generated when we first config the web. The subsequence build will not change it. So we can safely change it.

@banghuazhao
Copy link
Owner

BTW, you can follow those steps to link the branch and commit to a GitHub issue, which enables automatic closing upon merging, follow these steps:

Step 1: Create a Branch with the Issue Number

Include the issue number in the branch name to make it easier to track. For example, if the issue number is #22, you can name the branch:

git checkout -b Fix-issue-22-update-web-title

Step 2: Edit the Title in index.html

Make your changes to the index.html file as described earlier.

Step 3: Commit the Changes with an Issue Reference

In your commit message, reference the issue number and include keywords for automatic closing. For example:

git add .
git commit -m "Fix #22: Update webpage title to Composites AI"

Using "Fix #22" (or similar keywords like "Closes #22" or "Resolves #22") will automatically close the issue once this branch is merged.

Step 4: Push the Branch to the Remote Repository

Step 5: Create a Pull Request

I will review the pull request and merge it. The pull request will also run github action to compile the project and run tests

@wenbinyu-PU
Copy link
Collaborator Author

can I resolve multiple issues using "Fix #22, #23: ...."?

@banghuazhao
Copy link
Owner

banghuazhao commented Oct 17, 2024

Yes, to close multiple issues in a single commit, you could use the closing keywords (e.g., "Fixes", "Closes") before each issue number. Here's the correct syntax:

  • Correct: Fixes #22, fixes #23: [commit message]
  • Correct: Closes #22 and closes #23: [commit message]
  • Incorrect: Fix #22, #23: [commit message]

BTW, I have created the pull request for your branch: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants