-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purgeUnmanagedConfig does not function as documented #238
Comments
I agree, the documentation could be improved with regards to the garbage collection. The reason for this discrepancy with roles not being removed, is that https://github.com/banzaicloud/bank-vaults/pull/1513 only introduced garbage collection of the unmanaged |
Describe the bug:
This is a followup to https://github.com/banzaicloud/bank-vaults/issues/605. The functionality of purgeUnmanagedConfig does not function as documented (https://banzaicloud.com/docs/bank-vaults/external-configuration/purge-unmanaged-configuration). The documentation claims that purgeUnmanagedConfig gives you "full control" by removing any unmanaged configuration, and once enabled "any changes not in Bank-Vaults configuration will be removed (including manual changes)." When I add a line in externalConfig to create a k8s role, then later remove it, the role is not cleaned up. The same is true when adding and removing an ldap group. The only way I'm able to clean up auth configuration via external config is by deleting all auth config to disable the auth engine, then adding the auth config back in again.
Expected behaviour:
If I remove a single authentication role, group, etc. from my externalConfig, purgeUnmanagedConfig should clean it up.
Steps to reproduce the bug:
Add an auth role in externalConfig with purgeUnmanagedConfig enabled, reapply the vault cr with the line removed, and observe the role is not cleaned up on Vault.
Environment details:
bank-vaults version: 1.15.2
Install method: helm
Logs from the misbehaving component: no error logs; bank-vaults logs claim the configuration is successful.
/kind bug
The text was updated successfully, but these errors were encountered: