Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Option to force copy of binary image #5

Open
gschwaer opened this issue Dec 10, 2020 · 0 comments
Open

Feature request: Option to force copy of binary image #5

gschwaer opened this issue Dec 10, 2020 · 0 comments

Comments

@gschwaer
Copy link

I ran into a hard to debug situation: In a config.c I specified the same VM_IMAGE for multiple VMs, assuming this would be copied into an allocated memory region. However if the memory region where the entry address lies is not physically placed, the image will be mapped to the image in the config blob instead. So my two VMs where sharing the data sections in the binary and strange side effects started to appear.

Feature request: When running identical binaries on different cores the binary has to be included in the config multiple times, which bloats the config binary (e.g., 4x identical Linux kernel binary). Introducing a flag to force a copy would reduce the size of the config blob drastically in those cases.

I tried to implement that in vm_map_img_rgn but it didn't seem to work like this (freeze after boot):

if (reg->place_phys) {
->
if (reg->place_phys || config->image.force_copy) {

I guess I'm missing something, but couldn't figure out what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant