Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2 Public Client: estimateRelayMessageGas #58

Open
wilsoncusack opened this issue Sep 7, 2023 · 3 comments
Open

L2 Public Client: estimateRelayMessageGas #58

wilsoncusack opened this issue Sep 7, 2023 · 3 comments
Labels
state: backlog This is pending further review type: enhancement New feature or request type: question Further information is requested

Comments

@wilsoncusack
Copy link
Collaborator

OK so actually there's probably a subtask here that is estimateRelayMessageGas which would proxy to estimate gas from viem but set the caller to 0x0000000000000000000000000000000000000001, which is an address that will cause the function to revert if it is not relayed correctly.

from #55
@wilsoncusack
Copy link
Collaborator Author

I worked on this but not sure is worth doing given changing the from address makes a lot of transactions revert. Ie they need a specific msg.sender.

@wilsoncusack
Copy link
Collaborator Author

going to close for now

@wilsoncusack
Copy link
Collaborator Author

Actually, if you're using the crossChainMessenger then it shouldn't ever really matter who msg.sender is? The sender on the call to the contract is always going to be the crossChainMessenger? Probably still worth having. Thoughts @zencephalon @roninjin10 ?

@wilsoncusack wilsoncusack reopened this Sep 30, 2023
@wbnns wbnns added state: backlog This is pending further review type: enhancement New feature or request type: question Further information is requested labels Oct 4, 2023
@zencephalon zencephalon removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state: backlog This is pending further review type: enhancement New feature or request type: question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbnns @zencephalon @wilsoncusack