Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The option 'deep' in the method get_params triggers a different behaviour than sklearns implementation. #28

Open
c-w-feldmann opened this issue Jun 18, 2024 · 0 comments
Open

The option 'deep' in the method get_params triggers a different behaviour than sklearns implementation. #28

c-w-feldmann opened this issue Jun 18, 2024 · 0 comments
Labels
status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date
Milestone
v1.0.0

Comments

@c-w-feldmann
Copy link
Collaborator

In our implementation, deep=True will return the parameter as copy by value, whereas in sklearn this option will return the parameters of the object and the parameters of contained objects (Where the parameter name has the prefix object_name__).
I think we should adapt our behavior accordingly.
@c-w-feldmann c-w-feldmann added status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date labels Jun 18, 2024
@c-w-feldmann c-w-feldmann added this to the v1.0.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: backlog Things we will work on, but not right now type: maintenance Improvement of code or keeping the code up to date
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@c-w-feldmann