Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Type Pattern doesn't match Ec2NodeClass custom resources #48

Closed
kassof opened this issue Dec 10, 2024 · 6 comments
Closed

Resource Type Pattern doesn't match Ec2NodeClass custom resources #48

kassof opened this issue Dec 10, 2024 · 6 comments

Comments

@kassof
Copy link

kassof commented Dec 10, 2024

I use the bats-detik library to run functional tests on my EKS cluster. I would like to test the existence and status of a custom resource ec2nodeclass. But all tests on a ec2nodeclass resource type fail with "Invalid expression: it does not respect the expected syntax."

It's because the resource type pattern, in the utils.bash, does not accept numeric characters.

# The pattern for resource types
# (pod, PODs, complex.crd.resource, etc.)
 resource_type_pattern="[a-z][a-z.]+"

Is it possible to modify this regex to accept those numeric characters ?

@brokenpip3
Copy link

I assume that your are talking about an issue with the detik library right? https://github.com/bats-core/bats-detik
Let me see if I can move the issue to the right repo

@brokenpip3 brokenpip3 transferred this issue from bats-core/bats-core Dec 10, 2024
@brokenpip3
Copy link

Done, you are in the right repo now.

@vincent-zurczak
Copy link
Member

Hello @kassof.
Sure, we can update the pattern to support this resource name. I will tell you once it is done.

@vincent-zurczak
Copy link
Member

I have just pushed a PR: #49
Once it gets an approval, we will tag a new version.

vincent-zurczak added a commit that referenced this issue Dec 10, 2024
#48 Resource Type Pattern does not match Ec2NodeClass
@vincent-zurczak
Copy link
Member

The tag v1.3.3 has been released and fixes it.

@kassof
Copy link
Author

kassof commented Dec 13, 2024

Thanks a lot @vincent-zurczak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants