Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shellcheck #39

Open
leventyalcin opened this issue May 28, 2021 · 0 comments
Open

shellcheck #39

leventyalcin opened this issue May 28, 2021 · 0 comments

Comments

@leventyalcin
Copy link

While I was looking into CI outputs, there was printed lines for the version of the shellcheck. However, while I was looking into .bash files I noticed some anti-patterns such as commands running with backticks etc. So, it is not utilised.

Also, When I run shellcheck against .bash files, I see quite few errors. I think it could be a good practice to run shellcheck both on CI tests and as a pre-commit hook.

Creating this issue for starting a discussion but I can definitely take the task for myself and go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant