Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on batch_set_v2 #2

Open
beardyFace opened this issue Apr 10, 2024 · 0 comments
Open

Question on batch_set_v2 #2

beardyFace opened this issue Apr 10, 2024 · 0 comments

Comments

@beardyFace
Copy link

I'm trying to get my head around the difference in batch_set_v2 vs batch_set, are they functionally the same but different implementations for performance reasons? My understanding is the intent is to recreate the SumTree with the inverse priorities, then sample from it - or is there more going on with how v2 sets up the tree?

Why in batch_set_v2 do you skip updating anything if the length of the indices is not even? - ( "len(ind) % 2 == 0:"). My understanding is the SumTree can have an odd number of entries.

The parameter "t" which tracks back "self.total_it" doesn't appear to be used either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant