-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building docs errors because INSTALL.rst no longer exists #280
Comments
There is a proof of concept to autogenerate docs in PR #250, which also addresses this. As far as I can tell it still needs some work until it is ready, but it might be a good starting point. |
After a long struggle with GitHub actions, we now have multi-version docs on the branch I have inserted redirects for the HTML pages of the current version of the docs, so we should be able to switch without causing dead links. In principle, the new docs could go live by just switching the branch in the Github pages settings. When do we want this to happen, and for which releases/branches? Do we want to have mutli-version docs for v1? And do we already want to have public docs for the dev branch on bayesflow.org, or rather wait until the official release of v2? Tagging @stefanradev93 @paul-buerkner @LarsKue @marvinschmitt for opinions. As a note: Building the docs for v2 is quite heavy and takes around 15-20 minutes, total runtime for all versions is about 30 minutes. Do we want to set this up to only run when manually triggered? |
Thank you for making the docs work! This looks really cool! Our aim is to merge v2 start of next year, so I don't think it makes sense to have a mutli-version for v1. I believe a good time to publish the mutli docs of v2 would be shortly before its merging into main. This way, we could check if everything with the docs works out as we hope before we merge. I think running the full docs should only be done when manually triggered, say, before a release or after merging a larger PR. Is the slow runtime to be expected? |
Thanks for the feedback! The slow runtime is due to the way the autosummary is currently configured. We have basically three options to set up the docs:
We cannot simply disable |
It turned out that the configuration was not optimal yet. I have modified it, and now it runs at reasonable speed (5-8 minutes). With this, we could afford to run it more often if we want. This could also serve as a check if the documentation will still build after a commit/PR. The main remaining issue is how to exclude private members/modules, which we can discuss in #290. I will close this for now, feel free to reopen or open a new issue if you have ideas/requests for the API docs. |
See title. We need to rework the doc building workflow.
The text was updated successfully, but these errors were encountered: