Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate training flag to FlowMatching Integrator #288

Open
han-ol opened this issue Dec 20, 2024 · 2 comments
Open

Propagate training flag to FlowMatching Integrator #288

han-ol opened this issue Dec 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@han-ol
Copy link
Contributor

han-ol commented Dec 20, 2024 •
edited
Loading

Currently, dropout is ignored in FlowMatching.
I confirmed that the corresponding subnet_kwargs is propagated correctly to the subnet constructor. Nevertheless, dropout has no effect on training.

The Integrator and its subnet needs to receive a training=True flag to turn on dropout at training time.
@stefanradev93
Copy link
Contributor

@LarsKue Should we provide a hot fix or will you address this soon with the integrators refactor?

@LarsKue
Copy link
Contributor

LarsKue commented Dec 20, 2024

Will be addressed with the refactor.

@paul-buerkner paul-buerkner added the bug Something isn't working label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paul-buerkner @stefanradev93 @LarsKue @han-ol