Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Propagate Tags to Tar #776

Closed
Ryang20718 opened this issue Mar 4, 2024 · 1 comment
Closed

[FR]: Propagate Tags to Tar #776

Ryang20718 opened this issue Mar 4, 2024 · 1 comment
Labels
enhancement New feature or request untriaged Requires traige

Comments

@Ryang20718
Copy link

Ryang20718 commented Mar 4, 2024

What is the current behavior?

if we have tags such as no-remote-cache and a bazel remote cache, when using tar to create python docker images (giant images), we want to avoid pushing to the cache.

Describe the feature

We'd like to propagate tags to Tar so we avoid the remote cache

i.e
https://github.com/aspect-build/bazel-lib/blob/4f684081d752eb618c36d6627896738577c6effa/lib/private/tar.bzl#L151-L159

Happy to make a PR request, but wanted to ask if this would be acceptable first!

@Ryang20718 Ryang20718 added the enhancement New feature or request label Mar 4, 2024
@github-actions github-actions bot added the untriaged Requires traige label Mar 4, 2024
@alexeagle
Copy link
Collaborator

The tags should already propagate correctly. They are passed through here https://github.com/aspect-build/bazel-lib/blob/main/lib/tar.bzl#L131

Perhaps you're missing bazelbuild/bazel#8830 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

2 participants