We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The bsdtar supplied with bazel-lib doesn't support unicode in mtree files.
Bsdtar does seem to support locales, but only when compiled with HAVE_SETLOCALE https://github.com/libarchive/libarchive/blob/40ff837717b89e9a5d2c735758f503d124d17b72/tar/bsdtar.c#L190-L192
In the libarchive compilation that underpins this, it seems like we're configuring this for libarchive, but perhaps it isn't making its way to the bsdtar compilation? bazelbuild/bazel-central-registry@6050102#diff-7362d45a2c906ff9c0922ff1f104e88aa28197d9345dabbc18a7a5740f3959e6R1352
Does it also have to depend on //:config? I'm not particularly familiar with bazel cc rules.
//:config
The text was updated successfully, but these errors were encountered:
Looking into this further, I've confirmed that we are correctly compiling with HAVE_SETLOCALE. This looks like it actually might be an issue with how libarchive interprets mtree https://github.com/libarchive/libarchive/blob/40ff837717b89e9a5d2c735758f503d124d17b72/libarchive/archive_read_support_format_mtree.c#L1074-L1079
I think isprint here will fail on multibyte sequences, such as characters with a modifier like "ő".
isprint
Sorry, something went wrong.
No branches or pull requests
The bsdtar supplied with bazel-lib doesn't support unicode in mtree files.
Bsdtar does seem to support locales, but only when compiled with HAVE_SETLOCALE https://github.com/libarchive/libarchive/blob/40ff837717b89e9a5d2c735758f503d124d17b72/tar/bsdtar.c#L190-L192
In the libarchive compilation that underpins this, it seems like we're configuring this for libarchive, but perhaps it isn't making its way to the bsdtar compilation? bazelbuild/bazel-central-registry@6050102#diff-7362d45a2c906ff9c0922ff1f104e88aa28197d9345dabbc18a7a5740f3959e6R1352
Does it also have to depend on
//:config
? I'm not particularly familiar with bazel cc rules.The text was updated successfully, but these errors were encountered: