Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all available attributes #171

Open
glindstedt opened this issue Jul 1, 2023 · 0 comments
Open

Document all available attributes #171

glindstedt opened this issue Jul 1, 2023 · 0 comments

Comments

@glindstedt
Copy link

All available attributes should be documented in the main README.md to avoid confusion. So far I'm aware of:

  • data in _jsonnet_common_attrs
  • jsonnet in _jsonnet_common_attrs
  • extra_args in _jsonnet_compile_attrs

I lost several hours trying to work around not having the data attribute in a jsonnet_library rule, because it was not documented and I assumed the documentation was complete. I only found out it was already implemented when I was looking at the code with the intent of adding it myself.

If this seems reasonable I can help out drafting a PR

Related to #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant