Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entitlements dependency in rules_apple is no longer public (rules_apple 0.13.0) #154

Open
rahul-malik opened this issue Mar 5, 2019 · 1 comment
Open

Entitlements dependency in rules_apple is no longer public (rules_apple 0.13.0) #154

rahul-malik opened this issue Mar 5, 2019 · 1 comment

Comments

@rahul-malik
Copy link
Collaborator

Hammer.bzl currently depends on these load statements

load(
    "@build_bazel_rules_apple//apple/bundling:entitlements.bzl",
    entitlements_rule = "entitlements",
)
load(
    "@build_bazel_rules_apple//apple/bundling:entitlements.bzl",
    "AppleEntitlementsInfo",
)

These have been moved into internal rules and probably shouldn't be depended on anymore. We should revisit if our custom entitlement logic is still necessary given recent work on rules_apple
@rahul-malik rahul-malik changed the title Entitlements dependency in rules_apple is no longer public Entitlements dependency in rules_apple is no longer public (rules_apple 0.13.0) Mar 5, 2019
@rahul-malik
Copy link
Collaborator Author

This blocks upgrading to rules_apple 0.13.0

@rahul-malik rahul-malik mentioned this issue Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahul-malik