Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bzlmod: allow build_extra_args in gazelle_override #1647

Closed
casuallyhostile opened this issue Oct 10, 2023 · 1 comment · Fixed by #1648
Closed

Bzlmod: allow build_extra_args in gazelle_override #1647

casuallyhostile opened this issue Oct 10, 2023 · 1 comment · Fixed by #1648

Comments

@casuallyhostile
Copy link
Contributor

What version of gazelle are you using?

0.33.0

What version of rules_go are you using?

0.41.0

What version of Bazel are you using?

6.3.2

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

macOS arm64

What did you do?

I'm taming gazelle with bzlmod and want to pass an build_extra_args to gazelle_override e.g.

go_deps.gazelle_override(
    build_extra_args = ["-exclude=src"],
    path = "github.com/census-instrumentation/opencensus-proto",
)

fixing issue like
census-instrumentation/opencensus-proto#200 (comment)

@casuallyhostile casuallyhostile changed the title feature(bzlmod): allow build_extra_args in gazelle_override Allow build_extra_args in gazelle_override Oct 10, 2023
@fmeum
Copy link
Collaborator

fmeum commented Oct 10, 2023

This looks reasonable at least at first glance as this can't be pushed into a directive.

@tyler-french What do you think?

@casuallyhostile casuallyhostile changed the title Allow build_extra_args in gazelle_override Bzlmod: allow build_extra_args in gazelle_override Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants