Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Windows rbe_repo tests in CI #878

Open
sunjayBhatia opened this issue May 22, 2020 · 1 comment
Open

Enable Windows rbe_repo tests in CI #878

sunjayBhatia opened this issue May 22, 2020 · 1 comment

Comments

@sunjayBhatia
Copy link
Contributor

This issue is for tracking enabling rbe_repo tests in CI. Currently these are disabled as we don't have a CI environment that allows us to pull Windows Docker images. Once we do, we should enable the Windows tests in CI and potentially add some integration testing to add to Windows coverage.

In addition, we should change the container image used by the WORKSPACE rbe_autoconfig rules used for tests to one owned by the bazel-toolchains maintainers. Currently these rules use an image from the Envoy project Windows build toolchain.

These sections should be updated once we have a place to copy this container image:

bazel-toolchains/WORKSPACE

Lines 275 to 277 in 834b89b

digest = "sha256:776f241c2693f3f2187d998dcc98d2b339dcb80c99ef59bccefad0eea6e61284",
registry = "gcr.io",
repository = "envoy-ci/envoy-build-windows",

bazel-toolchains/WORKSPACE

Lines 424 to 431 in 834b89b

digest = "sha256:776f241c2693f3f2187d998dcc98d2b339dcb80c99ef59bccefad0eea6e61284",
export_configs = True,
registry = "gcr.io",
repository = "envoy-ci/envoy-build-windows",
toolchain_config_spec_name = "test_config_dir",
toolchain_config_suite_spec = {
"container_registry": "gcr.io",
"container_repo": "envoy-ci/envoy-build-windows",

regexp = "sha256:776f241c2693f3f2187d998dcc98d2b339dcb80c99ef59bccefad0eea6e61284",

We can probably copy the latest image from here to a bazel-toolchains owned repo in GCR: https://hub.docker.com/r/envoyproxy/envoy-build-windows2019/tags

@sunjayBhatia
Copy link
Contributor Author

cc @wrowe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant