New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbe_configs_gen produces wrongly formatted Starlark code (flagged by buildifier) #960

Open

davido opened this issue May 25, 2021 · 0 comments

davido commented May 25, 2021

I generate RBE config using this command:

  $ ./rbe_configs_gen \
  --bazel_version=4.1.0 \
  --toolchain_container=l.gcr.io/google/rbe-ubuntu18-04:latest \
  --output_src_root=/home/davido/projects/gerrit \
  --output_config_path=tools/rbe \
  --exec_os=linux \
  --target_os=linux

and running the latest buildifier utility on generated code produces this diff: [1].

Used buildifier version:

  $ buildifier -version
buildifier version: 4.0.0 
buildifier scm revision: 840218fa3afc7e7145c1eeb3bfeb612c497e67f7

[1] http://paste.openstack.org/show/805685

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment