Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Fix runtime_solib_name for --incompatible_macos_set_install_name #23185

Closed
bazel-io opened this issue Aug 1, 2024 · 3 comments
Closed

[7.4.0] Fix runtime_solib_name for --incompatible_macos_set_install_name #23185

bazel-io opened this issue Aug 1, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented Aug 1, 2024

Forked from #23089
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Aug 1, 2024
@iancha1992 iancha1992 mentioned this issue Aug 1, 2024
Closed
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java
src/main/starlark/builtins_bzl/common/cc/link/cpp_link_action.bzl

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkActionBuilder.java src/main/starlark/builtins_bzl/common/cc/link/cpp_link_action.bzl

cc: @bazelbuild/triage

cc: @fmeum @comius

@bazelbuild bazelbuild deleted a comment from bazel-io Sep 17, 2024
@fmeum fmeum mentioned this issue Sep 19, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23672

github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@fmeum
[7.4.0] Fix runtime_solib_name for `--incompatible_macos_set_instal…
4956dff 
…l_name` (#23672)

The `runtime_solib_name` link variable had an incorrect value in the
case of a transitive dynamic library. Since non-transitive ("nodeps")
dynamic libraries are no longer used on macOS, the
`--incompatible_macos_set_install_name` flag didn't have any positive
effect.

This PR is intentionally limited to the fix so that it can be
cherry-picked into Bazel 7, where it can make the incompatible flag work
with the `apple_support` toolchain. A follow-up PR will add the feature
to the Unix toolchain and flip the incompatible flag for Bazel 8.

Work towards #12370

Closes #23089.

PiperOrigin-RevId: 668228562
Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99

Fixes #23185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @iancha1992