Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 16 incompatibility #23639

Closed
lgalfaso opened this issue Sep 17, 2024 · 7 comments
Closed

Xcode 16 incompatibility #23639

lgalfaso opened this issue Sep 17, 2024 · 7 comments
Labels
team-Rules-CPP Issues for C++ rules team-Rules-ObjC Issues for Objective-C maintainers type: bug untriaged

Comments

@lgalfaso
Copy link

Description of the bug:

After updating to XCode 16, got the following error

ERROR: XXX/BUILD:7:11: Compiling xxx.cpp failed: absolute path inclusion(s) found in rule '//XXX':
the source file 'xxx.cpp' includes the following non-builtin files with absolute paths (if these are builtin files, make sure these paths are in your toolchain):
'/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/16/include/stdint.h'

Which category does this issue belong to?

C++ Rules

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Update to Xcode 16, and compile anything that uses 'stdint.h' (I would expect that this issue is not limited to stdint.h)

Which operating system are you running Bazel on?

MacOS 14.6.1

What is the output of bazel info release?

release 7.3.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-Rules-CPP Issues for C++ rules label Sep 17, 2024
@sgowroji sgowroji added the team-Rules-ObjC Issues for Objective-C maintainers label Sep 17, 2024
@tjgq
Copy link
Contributor

tjgq commented Sep 17, 2024

cc @keith

@fmeum
Copy link
Collaborator

fmeum commented Sep 17, 2024

Can you run bazel fetch --configure and see whether that fixes your build?

You may have to rerun this command if something non-hermetic (such as Xcode) changes on your machine.

@lgalfaso
Copy link
Author

After running

% bazel fetch --configure   
INFO: All external dependencies fetched successfully.
Computing main repo mapping: 

I'm still seeing the same error.

@lgalfaso
Copy link
Author

Running bazel fetch --force --configure did work :)

Thanks!

@fmeum fmeum reopened this Sep 17, 2024
@fmeum
Copy link
Collaborator

fmeum commented Sep 17, 2024

@meteorcloudy The behavior of bazel fetch --configure doesn't match that of bazel sync --configure. Requiring the additional --force seems unnecessary, what do you think?

I also noticed that --configure seems to be ignored if the command has a residue. That seems confusing, how about we make this case an error?

@meteorcloudy
Copy link
Member

@fmeum All sounds good to me! I can send a fix later this week.

fmeum added a commit to fmeum/bazel that referenced this issue Sep 20, 2024
With `bazel fetch`, `--configure` and `--force` are now independent and both need to be specified to refetch configure repos. The docs did not reflect this correctly.

Fixes bazelbuild#23639

Closes bazelbuild#23665.

PiperOrigin-RevId: 676520136
Change-Id: I07040c743c2b047f8511d1a42ea94d858c520011
iancha1992 pushed a commit that referenced this issue Sep 20, 2024
With `bazel fetch`, `--configure` and `--force` are now independent and both need to be specified to refetch configure repos. The docs did not reflect this correctly.

Fixes #23639

Closes #23665.

PiperOrigin-RevId: 676520136
Change-Id: I07040c743c2b047f8511d1a42ea94d858c520011
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules team-Rules-ObjC Issues for Objective-C maintainers type: bug untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants