Add --experimental_java_classpath=bazel_no_fallback option
#24876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-Java
|
does this mean that the change would need to be back-compatible with versions of |
cushon
requested changes
Jan 9, 2025
| classpathLine.add("--reduce_classpath_mode", fallback ? "BAZEL_FALLBACK" : "BAZEL_REDUCED"); | ||
| classpathLine.add("--reduce_classpath_mode", | ||
| fallback ? "BAZEL_FALLBACK" | ||
| : (classpathMode == JavaClasspathMode.BAZEL ? "BAZEL_REDUCED" : "BAZEL_REDUCED_NO_FALLBACK")); |
There was a problem hiding this comment.
Instead of adding the new --reduce_classpath_mode=BAZEL_REDUCED_NO_FALLBACK mode, did you consider having Bazel invoke JavaBuilder with a reduced classpath and pass --reduce_classpath_mode=NONE, and then handle not doing fallback on the Bazel side? I think that would provide equivalent behaviour without JavaBuilder changes.
There was a problem hiding this comment.
Thx, that's much better. Pushed the change.
There is still 1 test failure, but seems unrelated to the change:
test_size_less_than_385MB FAILED: terminated because this command returned a non-zero status:
/private/var/tmp/_bazel_buildkite/1198ee8566c303641c6d358da6949c16/sandbox/darwin-sandbox/4799/execroot/_main/bazel-out/darwin_arm64-fastbuild/bin/src/test/shell/integration/minimal_jdk_test.runfiles/_main/src/test/shell/integration/minimal_jdk_test:50: in call to test_size_less_than_385MB
…classpath_mode=NONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new option,
--experimental_java_classpath=bazel_no_fallback, which operates similarly to--experimental_java_classpath=bazelbut does not fall back to the full transitive classpath. Instead, the build fails if javac cannot compile with the reduced classpath.Fixes #24875