refactor: consolidate _bazel.bzl and remove semantics.bzl
#2522
Comments
This was referenced Dec 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 23, 2024
This furthers the work of removing the artificial split of code that stemmed from when the implementation was part of Bazel itself. Summary of changes: * Move most of `py_executable_bazel.bzl` into `py_executable.bzl` * Move most of `common_bazel.bzl` into `common.bzl` * Create `precompile.bzl` for the precompile helpers. This is to avoid a circular dependency between common.bzl and attributes.bzl. Work towards #2522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is to track work related to consolidating and cleaning up the code now that it's been moved out of Bazel itself. The main reason for this is to simplify the implementation. When the code was in Bazel itself, having separate files for Bazel and Google-internal pieces sense because carrying patches for the code was particularly hard. However, this ended up making the code somewhat complicated: (1) a "semantics" plugin object with quite a few "hooks" into various low-level steps and (2) the "hook points" have turned into a brittle API that make it hard to communicate state from one step to another.
Most low-hanging fruit has been cleaned up, the three main things remaining are:
py_executable_bazel.bzlintopy_executable.bzlcommon_bazel.bzlintocommon.bzlsemantics.bzlCleaning this up will probably expose some natural points of simplification in how things are implemented.
The text was updated successfully, but these errors were encountered: