Use canonical labels for analysistest config_settings #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With bzlmod enabled, errors like the following would occur:
Error in analysis_test_transition: invalid transition output '@[unknown repo '' requested from @bazel_skylib~1.3.0]//:clippy_flags': no repo visible as @ from repository '@bazel_skylib~1.3.0'
To resolve this, use str(Label("...")) to get the canonical label to use
as the key in config_settings.
Related issues: bazelbuild#2181, bazelbuild/bazel#19286
nickgooding
force-pushed
the
analysistest_canonical_labels
branch
from
29d5bab to
e711790
Compare
nickgooding
force-pushed
the
analysistest_canonical_labels
branch
from
e711790 to
a9e7396
Compare
UebelAndre
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With bzlmod enabled, errors like the following would occur:
To resolve this, use str(Label("...")) to get the canonical label to use as the key in config_settings.
Related issues: #2181, bazelbuild/bazel#19286