Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote environ when injecting into crates vendor wrapper #3078

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ryanpbrewster
Copy link
Contributor

Slight tweak to the logic in #2862 (cc: @UebelAndre)

My $PATH variable has spaces in it and I hit an error like

env: Support/JetBrains/Toolbox/scripts:/Users/ryanpbrewster/.bin:/Users/ryanpbrewster/config/bin:/Users/ryanpbrewster/.local/bin:/Applications/Visual: No such file or directory                                                                     

If I manually modify bazel-bin/rust/crates_vendor.sh to modify

exec env - \
${_ENVIRON[@]} \

into

exec env - \
"${_ENVIRON[@]}" \

it starts working.

Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion added this pull request to the merge queue Dec 10, 2024
Merged via the queue into bazelbuild:main with commit 4e0d0ab Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants