Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code from #116 to get it merged. #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cocampbe
Copy link

@cocampbe cocampbe commented Jun 2, 2021

Really need ability to pass java_opts. I saw #116 and decided to make the corrections.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cocampbe
Copy link
Author

cocampbe commented Jun 7, 2021

Good, bad, ugly?

@baztian
Copy link
Owner

baztian commented Jun 10, 2021

Thanks @cocampbe it actually looks good to me. Unfortunately I'm having issues with the Jython builds. But this is not due to one of your changes but to some incompatibilities introduces in some lib used during build. So I'm wondering if I finally should drop Jython support.

@kouddy
Copy link

kouddy commented Nov 29, 2021

Hey @baztian, my team also need the ability to specify Java options.

Seems like this feature is frequently requested by consumers of JayDeBeAPI as there has been number of pull request for this (#116 and #166)

If this change looks good, could you merge the pull request and publish a new version, please?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants