Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing permissions to read Org/Members lead to skipped reminders #169

Open
bbaga opened this issue Jul 7, 2022 · 0 comments
Open

Missing permissions to read Org/Members lead to skipped reminders #169

bbaga opened this issue Jul 7, 2022 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation github

Comments

@bbaga
Copy link
Owner

bbaga commented Jul 7, 2022

Describe the bug
When the search-prs-by-reviewers used to filter for teams and the application doesn't have permission to read org membership information, the search will fail which will cause the notification task to be skipped.

To Reproduce
Remove the the Organization/Members read permission and use the search-prs-by-reviewers source to search for teams.

Expected behavior
Instead of skipping the whole notification, the issue should be logged and the rest of the results should be shown.

Additional context
Documentation should be updated with the required permissions.

Version/Tag: 0.11.0-beta.5

@bbaga bbaga added the bug Something isn't working label Jul 7, 2022
@bbaga bbaga self-assigned this Jul 7, 2022
@bbaga bbaga added github documentation Improvements or additions to documentation labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation github
Projects
None yet
Development

No branches or pull requests

1 participant