Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Logger can't assign with console in Typescript #93

Open
cloud-hai-vo opened this issue Mar 11, 2019 · 2 comments
Open

Logger can't assign with console in Typescript #93

cloud-hai-vo opened this issue Mar 11, 2019 · 2 comments
Assignees
Labels

Comments

@cloud-hai-vo
Copy link
Contributor

Hi @nspragg,

Have type error in our current logger when try to use the console for logger https://github.com/bbc/flashheart/blob/master/src/core/clientParams.ts#L20

interface LogMethod {
  (message: string, callback: LogCallback): Logger;
  (message: string, meta: any, callback: LogCallback): Logger;
  (message: string, ...meta: any[]): Logger;
  (infoObject: object): Logger;
}

image

Do I need to do have custom class to implement the Logger interface?

@nspragg nspragg added the triage label May 9, 2019
@nspragg nspragg self-assigned this May 9, 2019
@nspragg nspragg added question and removed triage labels May 22, 2019
@nspragg
Copy link
Contributor

nspragg commented Jun 5, 2019

@cloud-hai-vo - is this still have issue for you?

@cloud-hai-vo
Copy link
Contributor Author

Hi @nspragg,

I do a workaround for it. In typescript still get the error with compiler

cloud-hai-vo added a commit to cloud-hai-vo/flashheart that referenced this issue Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants