diff --git a/.github/environments/values.dev.yaml b/.github/environments/values.dev.yaml index 97070503..61e00f30 100644 --- a/.github/environments/values.dev.yaml +++ b/.github/environments/values.dev.yaml @@ -4,6 +4,7 @@ config: configMap: FRONTEND_APIPATH: api/v1 FRONTEND_COMS_APIPATH: https://coms-dev.api.gov.bc.ca/api/v1 + FRONTEND_EXCLUDE_METADATA: geodrive.common.encoding,geodrive.windows.attr,geodrive.windows.secdesc,s3b-last-modified FRONTEND_NOTIFICATION_BANNER : This is the DEV environment of BCBox. Uploaded files may not persist and may be deleted from the COMS database as we continue development. Please do not upload personal or private information. Thank you for your understanding as we work to improve BCBox FRONTEND_OIDC_AUTHORITY: https://dev.loginproxy.gov.bc.ca/auth/realms/standard FRONTEND_OIDC_CLIENTID: bc-box-4555 diff --git a/.github/environments/values.prod.yaml b/.github/environments/values.prod.yaml index 54043e25..bb1eef75 100644 --- a/.github/environments/values.prod.yaml +++ b/.github/environments/values.prod.yaml @@ -4,6 +4,7 @@ config: configMap: FRONTEND_APIPATH: api/v1 FRONTEND_COMS_APIPATH: https://coms.api.gov.bc.ca/api/v1 + FRONTEND_EXCLUDE_METADATA: geodrive.common.encoding,geodrive.windows.attr,geodrive.windows.secdesc,s3b-last-modified FRONTEND_OIDC_AUTHORITY: https://loginproxy.gov.bc.ca/auth/realms/standard FRONTEND_OIDC_CLIENTID: bc-box-4555 SERVER_APIPATH: /api/v1 diff --git a/.github/environments/values.test.yaml b/.github/environments/values.test.yaml index 12087f25..149f3517 100644 --- a/.github/environments/values.test.yaml +++ b/.github/environments/values.test.yaml @@ -4,6 +4,7 @@ config: configMap: FRONTEND_APIPATH: api/v1 FRONTEND_COMS_APIPATH: https://coms-test.api.gov.bc.ca/api/v1 + FRONTEND_EXCLUDE_METADATA: geodrive.common.encoding,geodrive.windows.attr,geodrive.windows.secdesc,s3b-last-modified FRONTEND_NOTIFICATION_BANNER: This is the TEST environment of BCBox. Uploaded files may not persist and may be deleted from the COMS database as we continue development. Please do not upload personal or private information. Thank you for your understanding as we work to improve BCBox FRONTEND_OIDC_AUTHORITY: https://test.loginproxy.gov.bc.ca/auth/realms/standard FRONTEND_OIDC_CLIENTID: bc-box-4555 diff --git a/app/config/custom-environment-variables.json b/app/config/custom-environment-variables.json index c4832211..0ca20380 100644 --- a/app/config/custom-environment-variables.json +++ b/app/config/custom-environment-variables.json @@ -4,6 +4,10 @@ "coms": { "apiPath": "FRONTEND_COMS_APIPATH" }, + "exclude": { + "metadata": "FRONTEND_EXCLUDE_METADATA", + "tagset": "FRONTEND_EXCLUDE_TAGSET" + }, "notificationBanner": "FRONTEND_NOTIFICATION_BANNER", "oidc": { "authority": "FRONTEND_OIDC_AUTHORITY", diff --git a/app/config/default.json b/app/config/default.json index 1863dcb1..ef9ab1ac 100644 --- a/app/config/default.json +++ b/app/config/default.json @@ -1,6 +1,9 @@ { "frontend": { - "apiPath": "api/v1" + "apiPath": "api/v1", + "exclude": { + "tagset": "coms-id" + } }, "server": { "apiPath": "/api/v1", diff --git a/charts/bcbox/Chart.yaml b/charts/bcbox/Chart.yaml index cac25818..1d5373ac 100644 --- a/charts/bcbox/Chart.yaml +++ b/charts/bcbox/Chart.yaml @@ -3,7 +3,7 @@ name: bcbox # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.0.9 +version: 0.0.10 kubeVersion: ">= 1.13.0" description: A frontend UI for managing access control to S3 Objects # A chart can be either an 'application' or a 'library' chart. diff --git a/charts/bcbox/values.yaml b/charts/bcbox/values.yaml index 8b793356..ff1e6490 100644 --- a/charts/bcbox/values.yaml +++ b/charts/bcbox/values.yaml @@ -113,6 +113,8 @@ config: configMap: FRONTEND_APIPATH: "api/v1" FRONTEND_COMS_APIPATH: ~ + # FRONTEND_EXCLUDE_METADATA: ~ + # FRONTEND_EXCLUDE_TAGSET: ~ # FRONTEND_NOTIFICATION_BANNER: ~ FRONTEND_OIDC_AUTHORITY: ~ FRONTEND_OIDC_CLIENTID: ~ diff --git a/frontend/src/components/object/ObjectFilters.vue b/frontend/src/components/object/ObjectFilters.vue index 0743202d..efded0fe 100644 --- a/frontend/src/components/object/ObjectFilters.vue +++ b/frontend/src/components/object/ObjectFilters.vue @@ -86,8 +86,6 @@ const tagsetValues = computed(() => { .flatMap((obj) => obj.tagset) // Add a display property to each tag to be used by the multiselect .map((val) => ({ ...val, display: `${val.key}=${val.value}` })) - // coms-id not allowed as a tag to filter on by COMS - .filter((val) => val.key !== 'coms-id') // Unique by display property .filter( (val, index, self) => @@ -116,7 +114,7 @@ const selectedMetadataChanged = (event: MultiSelectChangeEvent) => { }; const selectedTagsChanged = (event: MultiSelectChangeEvent) => { // Unselect any other tags that have the same tag key - // e.g. if 'coms-id=1234' is selected, unselect any other tags that have 'coms-id' as the key + // e.g. if 'colour=red' is selected, unselect any other tags that have 'colour' as the key uncheckOther(event, selectedTags); selectedFilterValuesChanged(); }; diff --git a/frontend/src/components/object/ObjectMetadataTagForm.vue b/frontend/src/components/object/ObjectMetadataTagForm.vue index 7eb35362..d37ae928 100644 --- a/frontend/src/components/object/ObjectMetadataTagForm.vue +++ b/frontend/src/components/object/ObjectMetadataTagForm.vue @@ -65,8 +65,7 @@ onBeforeMount(() => { // Empty arrays can be given which won't trigger default prop values so check to see if blank rows need to be added initialValues.metadata = initialValues.metadata?.length ? initialValues.metadata : [{ key: '', value: '' }]; - // Filter coms-id first before determining initial set - initialValues.tagset = initialValues.tagset?.filter( (x: {key: string, value: string}) => x.key !== 'coms-id' ); + // Determine initial set initialValues.tagset = initialValues.tagset?.length ? initialValues.tagset : [{ key: '', value: '' }]; }); diff --git a/frontend/src/components/object/ObjectSidebar.vue b/frontend/src/components/object/ObjectSidebar.vue index 3fddd3b1..c32151e9 100644 --- a/frontend/src/components/object/ObjectSidebar.vue +++ b/frontend/src/components/object/ObjectSidebar.vue @@ -33,7 +33,6 @@ const closeObjectInfo = async () => { }; const obj = objectStore.findObjectById(props.objectId); -const bucketId = obj?.bucketId; watch( props, () => { if( obj && @@ -70,12 +69,10 @@ watch( props, () => { :full-view="false" /> diff --git a/frontend/src/components/object/ObjectTag.vue b/frontend/src/components/object/ObjectTag.vue index b8ef592a..923678ea 100644 --- a/frontend/src/components/object/ObjectTag.vue +++ b/frontend/src/components/object/ObjectTag.vue @@ -89,10 +89,7 @@ watch( [props, tsGetTagging, vsGetTagging], () => {