Refactor next.js anti-patterns

[shon-button]

Description of the Tech Debt

• NonAttributatbleEmissions (async server component) unnecessarily wraps NonAttributatbleEmissionsForm (sync client component) in a Suspense boundary.
• Page routes not using defaultPageFactory

Development Checklist:

• Refactored async app route pages to use bciers/libs/components/src/nextPageFactory/defaultPageFactory.tsx
• Import generic props HasReportVersiojn; HasFacilityId where applicable
• Rename files to *Page; *Form where applicable

Example:

• Rename bciers/apps/reporting/src/app/components/reportInformation/nonAttributableEmissions/NonAttributatbleEmissions.tsx to follow naming convention bciers/apps/reporting/src/app/components/reportInformation/nonAttributableEmissions/NonAttributatbleEmissionsPage.tsx
• In file bciers/apps/reporting/src/app/components/reportInformation/nonAttributableEmissions/NonAttributatbleEmissionsPage.tsx
  • remove Suspense wrapper of NonAttributatbleEmissionsFrom.tsx
  • refactor props to use interface HasFacilityId
• In file bciers/apps/reporting/src/app/components/reportInformation/nonAttributableEmissions/NonAttributatbleEmissionsForm.tsx
  • refactor props to use interface HasFacilityId
• In file, bciers/apps/reporting/src/app/bceidbusiness/industry_user/reports/[version_id]/facilities/[facility_id]/production-data/page.tsx refactor route page to follow page factory pattern using bciers/libs/components/src/nextPageFactory/defaultPageFactory.tsx
• In file, bciers/apps/reporting/src/app/bceidbusiness/industry_user_admin/reports/[version_id]/facilities/[facility_id]/production-data/page.tsx refactor route page to follow page factory pattern using bciers/libs/components/src/nextPageFactory/defaultPageFactory.tsx