Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spatial output options to downscale #131

Closed
CeresBarros opened this issue Dec 14, 2023 · 3 comments
Closed

Adding spatial output options to downscale #131

CeresBarros opened this issue Dec 14, 2023 · 3 comments
Labels
enhancement New feature or request question Further information is requested to do

Comments

@CeresBarros
Copy link
Member

I was wondering if it'd make sense to add an option to output the downscaled variables as a spatial object instead of a data.table. Perhaps a vector object?

I only foresee one issue at this point, which is the lat of projection/spatial metadata info in the xyz input object. A solution would be to add bbox as an optional argument (from which we'd extract spatial metadata) or a CRS argument.

Thoughts?

@CeresBarros CeresBarros added the question Further information is requested label Dec 14, 2023
@kdaust
Copy link
Collaborator

kdaust commented Dec 14, 2023

That would probably make sense - would we use sf or terra? So far I've found sf is faster for vector data than terra, but would require adding another dependency. Also - would this be related to providing optional raster output for downscaled variables?

Re: crs, it's required that the input is in epsg:4326, so I think we can just output in that projection.

@CeresBarros
Copy link
Member Author

I would use terra as we're not going to do spatial operations, just convert the data.table to a spatial object.

Good to know about the CRS. That should be documented and checked accordingly -- I'll take care of that.

@CeresBarros
Copy link
Member Author

done in #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested to do
Projects
None yet
Development

No branches or pull requests

2 participants