NFFD doesn't match ClimateNA

[cmahony]

NFFD not matching between climr and ClimateNA. at an annual level, it seems to be related to longitude

on a monthly level it is confined to latitudinal regions

[cmahony]

code for these plots is https://github.com/bcgov/climr/blob/devl/tests/check_CompareClimateNA.R

[cmahony]

I've taken a look and haven't found an error in our code. The only associated variable is Tmin, and there are no discrepancies.

one key thing is that the NFFD parameters published in Wang (2016) are not what is used in ClimateNA. Tongli provided us with alternative parameters, see #68. perhaps importantly, those equations are for "NFFD_wna", suggesting they were originally calibrated for WNA. it is outside the ClimateWNA domain that we are seeing this discrepancy in NFFD. it seems likely that Tongli may have updated the parameters for eastern North America.

[cmahony]

downgrading priority to V1, and entering as a known issue. we'll get in touch with tongli to see if there are updated parameters for ENA

[cmahony]

Note that PAS has a similar pattern. PAS was the other variable set that tongli provided us wiht WNA parameters for.