Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - Display Accurate Organization Balance by Subtracting “In Reserve” #1575

Closed
5 tasks
AlexZorkin opened this issue Dec 31, 2024 · 3 comments
Closed
5 tasks
Assignees
Labels
High High priority ticket but not critical at this time Task Work that does not directly impact the user

Comments

@AlexZorkin
Copy link
Collaborator

AlexZorkin commented Dec 31, 2024

Description:
The system currently shows the total balance without deducting the “in reserve” portion on the frontend. We need to modify the logic to subtract the in reserve balance from the total balance, thereby presenting a realistic value for the usable balance.

Purpose and benefit to user:
Accurate displays of available credits prevent misunderstandings and improve user confidence in the data. Subtracting “in reserve” amounts allows stakeholders to see their actual usable credits at a glance.

Acceptance Criteria:

  • Given the user is viewing the organization’s balance, when the page loads, then the displayed balance correctly represents total_balance - reserved_balance.
  • Given the user interacts with any functionality that recalculates or refreshes the balance, then the front end continues to show the updated usable balance.

Development Checklist:

  • Calculate usable_balance by subtracting the in reserve balance from the total.
  • Display the resulting usable balance in all relevant UI components.
  • Conduct testing in the development and test environments to confirm the accuracy of displayed values.

Notes:
Ensure that any existing views or reports referencing balances align with this new calculation, and confirm that downstream calculations or actions rely on the updated values.

These are pages that display credit balance

  • BCeID header
  • BCeID dashboard
  • IDIR dashboard
  • IDIR organization page
  • IDIR transactions page (after using organization select list)
  • IDIR transfer page
@AlexZorkin AlexZorkin added Medium Medium priority Task Work that does not directly impact the user labels Dec 31, 2024
@airinggov airinggov added High High priority ticket but not critical at this time and removed Medium Medium priority labels Jan 3, 2025
@dhaselhan dhaselhan self-assigned this Jan 8, 2025
@Grulin Grulin added the Tested :) Testing passed label Jan 10, 2025
@Grulin Grulin closed this as completed Jan 10, 2025
@airinggov
Copy link
Collaborator

@Grulin I don't think this is working properly yet

@Grulin Grulin removed the Tested :) Testing passed label Jan 14, 2025
@Grulin
Copy link
Collaborator

Grulin commented Jan 14, 2025

@airinggov I think you are right and Alex and I spoke about this at length yesterday. I have written you a Teams message about it

@airinggov
Copy link
Collaborator

airinggov commented Jan 15, 2025

card was reverted, this was my error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High High priority ticket but not critical at this time Task Work that does not directly impact the user
Projects
None yet
Development

No branches or pull requests

4 participants