From ba0d5fa11cc9a2b420ce2d388022304891795f00 Mon Sep 17 00:00:00 2001
From: Rajandeep98 <144159721+Rajandeep98@users.noreply.github.com>
Date: Tue, 31 Oct 2023 14:37:24 -0700
Subject: [PATCH] 18068 - Namerequest UI: Editing the Resubmit NR has the first
 name choice as empty. (#740)

* updated condition for SP/GP resubmission

* Updated designation checking with designation type

* Simplified conditional and updated flag name

* version up
---
 package-lock.json    | 4 ++--
 package.json         | 2 +-
 src/store/actions.ts | 5 +++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 3ce8df208..d38eb6acb 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "name-request",
-  "version": "5.3.4",
+  "version": "5.3.5",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "name-request",
-      "version": "5.3.4",
+      "version": "5.3.5",
       "dependencies": {
         "@babel/compat-data": "^7.21.5",
         "@bcrs-shared-components/breadcrumb": "2.1.24",
diff --git a/package.json b/package.json
index 4595acf4c..a5414697f 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "name-request",
-  "version": "5.3.4",
+  "version": "5.3.5",
   "private": true,
   "appName": "Name Request UI",
   "sbcName": "SBC Common Components",
diff --git a/src/store/actions.ts b/src/store/actions.ts
index 45434ea92..2d2adad35 100644
--- a/src/store/actions.ts
+++ b/src/store/actions.ts
@@ -489,14 +489,15 @@ export const resubmit = async ({ commit, getters }): Promise<boolean> => {
 
   // add resubmit NR number (for internal use only - API ignores it)
   nrTypeData['resubmitNrNum'] = nrData['nrNum']
-
+  // check against entity types if it should have designation or not : if length returns to be 0 then NR should not have any designation otherwise work as getNameDesignation
+  const checkEntityType = Designations[nrData['entity_type_cd']].words.length === 0
   // clean names data
   nrTypeData['names'] = nrData.names.map(name => ({
     choice: name.choice,
     consent_words: '',
     conflict1: '',
     conflict1_num: '',
-    designation: getNameDesignation(name),
+    designation: !checkEntityType ? getNameDesignation(name) : '',
     name: name.name,
     name_type_cd: name.name_type_cd
   }))