Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments for step 4 - Orchard screen #1594

Closed
2 of 7 tasks
SLDonnelly opened this issue Sep 4, 2024 · 7 comments · Fixed by #1599
Closed
2 of 7 tasks

Adjustments for step 4 - Orchard screen #1594

SLDonnelly opened this issue Sep 4, 2024 · 7 comments · Fixed by #1599
Assignees
@mgaseta
Labels
front-end front-end related task middle-sprint Issues added after the beginning of the sprint test test related task

Comments

@SLDonnelly
Copy link
Collaborator

SLDonnelly commented Sep 4, 2024 •
edited
Loading

Describe the task
During refinement some FE adjustments were identified for the step 4 - Orchard screen. They are:

  1. Get rid of the plus/minus on the pollen breeding value field
  2. Make drop down fields the same width

Acceptance Criteria

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • QA from UX team
  • Manual testing of all PRs in Dev and Prod
  • Merged

Additional context

Image
@ngunner15 ngunner15 self-assigned this Sep 5, 2024
@ngunner15 ngunner15 added the front-end front-end related task label Sep 5, 2024
@mgaseta
Copy link
Collaborator

mgaseta commented Sep 5, 2024

Talked with the dev team and we agreed to add another bug to this issue, regarding the primary and secondary orchard fields, here is the description and steps to reproduce:

Secondary orchard appearing on the primary orchard dropdown

Steps to repro:

  1. Select a primary orchard
  2. Add a secondary one
  3. Clear the primary field
  4. The one selected as secondary is appearing on the primary dropdown

The acceptance criteria is the same as the "main" description.

@ngunner15 ngunner15 added the test test related task label Sep 5, 2024
@ngunner15
Copy link
Collaborator

Describe the task During refinement some FE adjustments were identified for the step 4 - Orchard screen. They are:

  1. Get rid of the plus/minus on the pollen breeding value field
  2. Make drop down fields the same width

Acceptance Criteria

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • QA from UX team
  • Manual testing of all PRs in Dev and Prod
  • Merged

Additional context

Image

Completed

@ngunner15
Copy link
Collaborator

Talked with the dev team and we agreed to add another bug to this issue, regarding the primary and secondary orchard fields, here is the description and steps to reproduce:

Secondary orchard appearing on the primary orchard dropdown

Steps to repro:

  1. Select a primary orchard
  2. Add a secondary one
  3. Clear the primary field
  4. The one selected as secondary is appearing on the primary dropdown

The acceptance criteria is the same as the "main" description.

While resolving this bug, I found removeSelectedOption removes Orchard from primary Orchard, it does not remove from secondary Orchard -

nr-spar/frontend/src/components/SeedlotRegistrationSteps/OrchardStep/index.tsx

Lines 193 to 203 in 8d416f3

const removeSelectedOption = (data: MultiOptionsObj[]) => {
const filteredOptions: MultiOptionsObj[] = structuredClone(data);
const orchardId = state.orchards.primaryOrchard.value.code;
// The index of a matching orchard in filteredOptions
const orchardOptIndex = filteredOptions.findIndex((option) => option.code === orchardId);
if (orchardOptIndex > -1) {
// Remove found option
filteredOptions.splice(orchardOptIndex, 1);
}
return filteredOptions;
};

@ngunner15 ngunner15 mentioned this issue Sep 5, 2024
Merged
3 tasks
@ngunner15 ngunner15 linked a pull request Sep 5, 2024 that will close this issue
feat: 1594 adjustments for orchard screen #1599
Merged
3 tasks
@RMCampos RMCampos assigned mgaseta and unassigned ngunner15 Sep 9, 2024
@ngunner15
Copy link
Collaborator

  1. Weird behaviour when clicking 'Add additional orchard' button -

Image

  1. Clicking 'Cancel' button should not remove orchard -

Image

  1. Clicking 'x' does not show popup -

Image

@mgaseta mgaseta added the middle-sprint Issues added after the beginning of the sprint label Sep 17, 2024
@RMCampos RMCampos mentioned this issue Sep 9, 2024
Closed
@ngunner15
Copy link
Collaborator

No 2. issue resolved

@mgaseta
Copy link
Collaborator

mgaseta commented Sep 24, 2024

  1. Weird behaviour when clicking 'Add additional orchard' button -

Image

    [
      
    
        ![Image](https://github.com/user-attachments/assets/fb65ef57-3147-4899-b9ab-df15047f008f)
      ](https://private-user-images.githubusercontent.com/31422051/367950851-fb65ef57-3147-4899-b9ab-df15047f008f.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTEtZmI2NWVmNTctMzE0Ny00ODk5LWI5YWItZGYxNTA0N2YwMDhmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwZWMzNTdiYzNkZmFiOWUxYWViMTUxYWEyZjBkNTdiMTYyOTg0MTkxNDZlMDZlODMzMmQzZjVjYWE5YTQ4M2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0SP4A2F8Ncq5qY0C8yboWdai5jbIvoyv0Ta9TP1qYGo)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/31422051/367950851-fb65ef57-3147-4899-b9ab-df15047f008f.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTEtZmI2NWVmNTctMzE0Ny00ODk5LWI5YWItZGYxNTA0N2YwMDhmLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAwZWMzNTdiYzNkZmFiOWUxYWViMTUxYWEyZjBkNTdiMTYyOTg0MTkxNDZlMDZlODMzMmQzZjVjYWE5YTQ4M2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0SP4A2F8Ncq5qY0C8yboWdai5jbIvoyv0Ta9TP1qYGo)
  1. Clicking 'Cancel' button should not remove orchard -

Image

    [
      
    
        ![Image](https://github.com/user-attachments/assets/4446b90c-629b-4a4d-8cf2-772afae89741)
      ](https://private-user-images.githubusercontent.com/31422051/367950850-4446b90c-629b-4a4d-8cf2-772afae89741.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTAtNDQ0NmI5MGMtNjI5Yi00YTRkLThjZjItNzcyYWZhZTg5NzQxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmZTdlMGNkNjcwYzI4ZTBiMjMyNGU4MjlkY2I0YWNmMGUxYzljOTEwNTkwOTI3ZDY2YjQ0YjExMDg1ZDkwODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4w5M3CiMljUr5YgGksOGnICz9f3hZwrZCNTYWn141CY)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/31422051/367950850-4446b90c-629b-4a4d-8cf2-772afae89741.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTAtNDQ0NmI5MGMtNjI5Yi00YTRkLThjZjItNzcyYWZhZTg5NzQxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmZTdlMGNkNjcwYzI4ZTBiMjMyNGU4MjlkY2I0YWNmMGUxYzljOTEwNTkwOTI3ZDY2YjQ0YjExMDg1ZDkwODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4w5M3CiMljUr5YgGksOGnICz9f3hZwrZCNTYWn141CY)
  1. Clicking 'x' does not show popup -

Image

    [
      
    
        ![Image](https://github.com/user-attachments/assets/ac2af163-79de-47fb-8684-6c51822790e1)
      ](https://private-user-images.githubusercontent.com/31422051/367950852-ac2af163-79de-47fb-8684-6c51822790e1.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTItYWMyYWYxNjMtNzlkZS00N2ZiLTg2ODQtNmM1MTgyMjc5MGUxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzYTI1YTFmNmNkZDAwMDU4MTljZThiODg5ZDhkOGQ3NmM0NWQ5NmYxNDhlZjI1NjY3Mjg1NDQxOWVjZjY1MWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iCCzOvPO2Tg3sak1VwVe6Dm_R1gkdLMYJx6g8K8Srsk)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/31422051/367950852-ac2af163-79de-47fb-8684-6c51822790e1.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY2OTA5ODAsIm5iZiI6MTcyNjY5MDY4MCwicGF0aCI6Ii8zMTQyMjA1MS8zNjc5NTA4NTItYWMyYWYxNjMtNzlkZS00N2ZiLTg2ODQtNmM1MTgyMjc5MGUxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE4VDIwMTgwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzYTI1YTFmNmNkZDAwMDU4MTljZThiODg5ZDhkOGQ3NmM0NWQ5NmYxNDhlZjI1NjY3Mjg1NDQxOWVjZjY1MWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iCCzOvPO2Tg3sak1VwVe6Dm_R1gkdLMYJx6g8K8Srsk)

On issue 3. it won't show the popup if the user haven't accessed step 5, since the table was not loaded, so that behavior is expected.

@mgaseta mgaseta mentioned this issue Sep 24, 2024
Open
@mgaseta
Copy link
Collaborator

mgaseta commented Sep 24, 2024 •
edited
Loading

The new fixes should unblock you @ngunner15 as for the secondary orchard issue, I created a separate task to track it (#1634)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgaseta mgaseta

Labels
front-end front-end related task middle-sprint Issues added after the beginning of the sprint test test related task
Projects
SPAR Sprints | Goal: UI library testing and selection; Review lo-fi wireframes; Apply design changes as necessary; complete CONSEP seed testing activities usability testing
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 1594 adjustments for orchard screen bcgov/nr-spar
3 participants
@ngunner15 @SLDonnelly @mgaseta