-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDP Prod Issue: Error 500 displayed when exporting conversations in Employee Record page #1386
Comments
The employee demographics record for EE 061623 has a dept ID 100-3507. The employee demo department ID is mapped to an Org ID by the nightly process for pulling the employee demographics from ODS. PDP retrieves department information from PDP thru another nightly process for generating department tree. 100-3507 is no longer available in the currently generated tree. This may happen due to re-orgs within BC Gov. In Employee Record page, Org ID is used to retrieve the 4-level departments, and is currently required to retrieve the necessary details displayed in the PDF file. The open and closed conversations does not display the 4-level departments. The 4-level department details seems to be not required or may be optional for the generated PDF. The export displays the error 500 when the 4-level dept details is not found, due to missing Org ID. The issue may not be limited to EE 061623. This issue could potentially happen to other employees with mismatching dept ID to 4-level depts. The 500 Server Error is NOT a result of the #1379 change. The simplest fix is to make the 4-level dept optional (or not required) in the Export PDF. |
…issing 4-level depts ZenHub #1386 - Fix join issue in PDF export for Employee Record for missing 4-level depts
Issue replicated in Test, after syncing employee demo details. |
…issing 4-level depts ZenHub #1386 - Fix join issue in PDF export for Employee Record for missing 4-level depts
@jessicahjwu I've deployed the fix in Test. The export button is working again. |
@jessicahjwu Training data for 061623 is now setup like in Prod. Training is setup with a higher debug setting. Does not show Error 500, but shows the actual error in the PHP code. |
@telusdcinco Not sure why the error shows for PHP code but can we have it fixed? I'd also like to see if we can manually do the following in Test and Training so I can validate the function (as 061623 did not have any completed conversations in Test/Training): Scenario 1 - Past Employee with a department ID that's no longer existing
Scenario 2 - Past Employee with a valid department ID
|
Updates in Test and Training: EE 163102 updated to dept 100-3507 and date deleted of Jan 1 2024. The following processes ran manually for above changes to reflect across pages.
Checking with Warren on why Training is displaying debug page when this error occurs, instead of the generic Error 500 page. This issue is limited to Training only. Test and Prod are following the correct behavior as defined in the config file. |
If the PHP coding error doesn't affect Prod nor our testing to this specific item, let's not dig deeper for now. |
@jessicahjwu The 4-level dept pulling is now optional for Employee Records export function. |
…issing 4-level depts ZenHub #1386 - Fix join issue in PDF export for Employee Record for missing 4-level depts
@jessicahjwu Deployed to Training. Ready for your validation. |
Confirmed function working properly as expected, error message did not appear in Training for both scenarios: past employee with an non-existing department ID and past employee with a valid department ID. |
…issing 4-level depts ZenHub #1386 - Fix join issue in PDF export for Employee Record for missing 4-level depts
MIGRATION NOTES: Code change only. |
@jessicahjwu Deployed to Prod. App pods restarted. |
After implementing #1379 to Production Error 500 displayed when exporting conversations in Employee Record page for select employees like EE 061623.
The text was updated successfully, but these errors were encountered: