Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing page #4506

Closed
junminahn opened this issue Dec 13, 2024 · 6 comments
Closed

Billing page #4506

junminahn opened this issue Dec 13, 2024 · 6 comments
Assignees

Comments

@junminahn
Copy link
Collaborator

junminahn commented Dec 13, 2024

Description

  • Provide a list view of Billings for admin purposes.

Technical Details

  • Implement a read-only table displaying available billing data.
  • Follow the existing design pattern for list pages (e.g., product and request) to include similar filtering and pagination.
  • Add a new backend endpoint to support search functionality.

Definition of Done (DOD)

  • A global admin can search for billings.
@Kolezhanchik Kolezhanchik self-assigned this Jan 9, 2025
@funtigr
Copy link
Collaborator

funtigr commented Jan 16, 2025

Now we have a billing page that is available for public admins and global admins.
The billing information is displayed with licencePlates and billing codes that can be copied.
There are filters that allow to find not signed and/or not approved products, though there is a twist (mentioned below):
image.png

Suggestions that may be implemented in a separate task or added in terms of this one:

  • for me it looks a bit unusual that there are no product names in the table. If the billing code is unique for every product, then it is logical to mention the names of the product and/or licencePlates could be clickable for billing person to see the product. I can't think of a use case where a person would need billing codes and licencePlates without the names of the products.
  • another thing is about the Status tags. There are actually 3 statuses for the product after creation. If the product is signed by Expense Authority and Cloud Director, it gets Signed and Approved tags. But in this case it is not yet approved, it is just signed by two different roles and still needs an approval from Admin to go live. So actually Signed status should be split in 2: Signed by Expense Authority and Signed by Cloud Director.

@Kolezhanchik
Copy link
Collaborator

ticket says - Implement a read-only table displaying available billing data. - product name is not available in billing, and it is needed to pull product data in order to show product name
also billing model contains two fields signed and approved, there are no more fields to show about status.
if we need to change billing model, it is out of this ticket scope

@Kolezhanchik
Copy link
Collaborator

speaking about signed and approved, model window for billing review as well as button don't say "sign", but "review" and "approve"image.png

@funtigr
Copy link
Collaborator

funtigr commented Jan 16, 2025

@Kolezhanchik @golebu2020 @Iryna-Kaplun
The schema of how the Public Cloud request becomes a product now with representation of current matching tags.
image.png

I think we could use this kind of visual representation for the requests, which we already have in the Requests tab:
image.png

@Kolezhanchik
Copy link
Collaborator

Kolezhanchik commented Jan 16, 2025

it is about product not billing, could you, please, take a look at billing model?

@funtigr funtigr closed this as completed Jan 16, 2025
@funtigr
Copy link
Collaborator

funtigr commented Jan 16, 2025

I've created a follow up discussion task, closing this one for now:
https://app.zenhub.com/workspaces/app-dev-team-646fdb4400ed8c0021aceeb4/issues/gh/bcgov/platform-services-registry/4675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants