Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting course throws error when mod deft response is not installed #65

Open
lonesomewalker opened this issue Jan 26, 2024 · 0 comments

Comments

@lonesomewalker
Copy link

lonesomewalker commented Jan 26, 2024

Stack trace: 
line 77 of /mod/videotime/plugin/live/lib.php: Error thrown
line 7970 of /lib/moodlelib.php: call to videotimeplugin_live_delete_instance()
line 301 of /mod/videotime/lib.php: call to component_callback()
line 5167 of /lib/moodlelib.php: call to videotime_delete_instance()
line 5028 of /lib/moodlelib.php: call to remove_course_contents()
line 68 of /course/delete.php: call to delete_course()

After installing Deft response i was finally able to delete.

SERIOUSLY: who glued this together?

Related to mod/videotime/plugin/live/lib.php

function videotimeplugin_live_delete_instance($id) {
    global $DB;

    $DB->delete_records('videotimeplugin_live', array('videotime' => $id));
    \block_deft\janus_room::remove('videotimeplugin_live', $id);

    return true;
}

I have seen, in latest git version this is captured with an if statement (but not for older 3.11 release).

Be honest: are you even interested to maintain this anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant