Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion of improvement when embedding content for better user experience #79

Open
moodlemobile opened this issue Oct 8, 2024 · 0 comments

Comments

@moodlemobile
Copy link

In order to provide a better experience to users when embedding content from the site (for example, a Moodle site page with a code to embed a video) we recommend using our component "core-iframe" instead of just iframe as it will automatically log in the user into the site (Android and iOS)

Our suggestion will be to update this line:

<iframe src="{{ url }}" style="height: 100vw; width: 100%;"></iframe>

With something similar to was used here:
https://github.com/mattan-d/moodle-mod_stream/blob/master/templates/mobile_view_page.mustache#L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant