Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 TextBox and NumberBox's cursorWidth have erroneous documentation #1160

Open
jacksonb-cs opened this issue Dec 18, 2024 · 2 comments
Open
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jacksonb-cs
Copy link

jacksonb-cs commented Dec 18, 2024

Describe the bug
The default value of cursorWidth for both TextBox and NumberBox is stated to be 2. However:

  • TextBox.cursorWidth's default value is 1.
  • NumberBox.cursorWidth's default value is 1.5.

Arguably worse yet is the fact that both of these text boxes have different default cursor widths, which leads to visual inconsistency if they are used near one another.

Expected behavior
The documentation should be adjusted to match the real default values, although I recognize that may be tricky considering both fields are relying on macros to copy the docs from the Flutter framework. Furthermore, unless there is a reason for the difference, I believe their default values should match each other, preferably using TextBox's default value as the default for both.

@bdlukaa bdlukaa added bug Something isn't working documentation Improvements or additions to documentation labels Dec 18, 2024
@jacksonb-cs
Copy link
Author

Some adjacent things:

  • NumberBox.precision says default value is 2, but default value is really null.
  • NumberBox.pattern's documentation has a typo: "parttern".

@x-brymo
Copy link

x-brymo commented Dec 26, 2024

textbox fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants