Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label matching should also normalize sensor type/channels #65

Open
kleinschmidt opened this issue Feb 1, 2023 · 0 comments
Open

label matching should also normalize sensor type/channels #65

kleinschmidt opened this issue Feb 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kleinschmidt
Copy link
Member

we currently lowercase the input label strings during matching, but then we compare against the possibly un-normalized signal names/channel names. This creates a common footgun for users, who look at the EDF signal header and create labels to match the (often mixed case) signal/channel names found in the headers.

@kleinschmidt kleinschmidt added the enhancement New feature or request label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant