Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing units out from onda_samples_to_edf_signals #83

Open
ericphanson opened this issue Oct 10, 2023 · 1 comment
Open

Allow passing units out from onda_samples_to_edf_signals #83

ericphanson opened this issue Oct 10, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@ericphanson
Copy link
Member

in https://github.com/beacon-biosignals/OndaEDF.jl/blob/fc8709d84e2a55b77cd86d1f9fbc3003d5a95c6d/src/export_edf.jl#L189C1-L189C1

we call

function onda_to_edf_unit(onda_sample_unit::String, unit_alternatives=STANDARD_UNITS)
units = get(unit_alternatives, onda_sample_unit, missing)
return lift(first, units)
but don't allow hte user to choose the 2nd argument, so only standard units are supported.

We should allow passing custom units through onda_samples_to_edf_signals

@kleinschmidt
Copy link
Member

The current workaround for this is to modify the STANDARD_UNITS dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants