Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDF labels not preserved in Samples object #86

Open
ericphanson opened this issue Oct 12, 2023 · 2 comments
Open

EDF labels not preserved in Samples object #86

ericphanson opened this issue Oct 12, 2023 · 2 comments

Comments

@ericphanson
Copy link
Member

ericphanson commented Oct 12, 2023

as claimed by

The `label` of the original `EDF.Signal`s are preserved in the `:edf_channels`
field of the resulting `SamplesInfo`s for each `Samples` generated.

That is not possible with Legolas v0.5 / Onda v0.15. I think probably this info needs to be propagated out another way. I do think it's useful info to get.

@kleinschmidt
Copy link
Member

Oof, good catch. They're propagated in the plan table (for the reasons you mentioned). We could also define a schema extension which might be a better way to go if we really want to make sure that these labels are always propagated, even if you don't save the plan

@ericphanson
Copy link
Member Author

I think a schema extension wouldn't work since Onda.Samples requires SamplesInfoV2: https://github.com/beacon-biosignals/Onda.jl/blob/dd5d23bd17aab5b07520e40342421829516ef838/src/samples.jl#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants