Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h2spec tracking (80 passed, 14 failed) #44

Closed
fasterthanlime opened this issue Jan 3, 2023 · 7 comments
Closed

h2spec tracking (80 passed, 14 failed) #44

fasterthanlime opened this issue Jan 3, 2023 · 7 comments
Labels

Comments

@fasterthanlime
Copy link
Collaborator

fasterthanlime commented Jan 3, 2023

Ran h2spec today, with:

$ just h2spec-server
(cut)
Listening on [::]:8888
h2spec -p 8888 -o 1
(cut)
Finished in 49.2419 seconds
146 tests, 70 passed, 1 skipped, 75 failed

Even with a super naive implementation that fails to check for a lot of preconditions / stubs large parts of the spec, we're already off to a good start!

@fasterthanlime
Copy link
Collaborator Author

fasterthanlime commented Jan 4, 2023

I'm gonna update this comment with the latest results:

2023-01-21:

Finished in 43.2143 seconds
146 tests, 103 passed, 1 skipped, 42 failed

(What's neat is that, as tests get fixed, the suite gets faster, since most failures do a 1-second timeout)

edit: The test results are now tracked in CI, I'm editing the issue title now and then.

@fasterthanlime fasterthanlime changed the title h2spec tracking issue (146 tests, 70 passed, 1 skipped, 75 failed) h2spec tracking issue (146 tests, 77 passed, 1 skipped, 68 failed) Jan 4, 2023
@fasterthanlime fasterthanlime changed the title h2spec tracking issue (146 tests, 77 passed, 1 skipped, 68 failed) h2spec tracking issue (146 tests, 81 passed, 1 skipped, 64 failed) Jan 4, 2023
@github-actions github-actions bot removed the h2 label Jan 4, 2023
@fasterthanlime fasterthanlime changed the title h2spec tracking issue (146 tests, 81 passed, 1 skipped, 64 failed) h2spec tracking issue (146 tests, 89 passed, 1 skipped, 56 failed) Jan 4, 2023
@fasterthanlime fasterthanlime changed the title h2spec tracking issue (146 tests, 89 passed, 1 skipped, 56 failed) h2spec tracking issue (146 tests, 94 passed, 51 failed and 1 skipped.) Jan 21, 2023
@fasterthanlime fasterthanlime changed the title h2spec tracking issue (146 tests, 94 passed, 51 failed and 1 skipped.) h2spec tracking issue (103 passed, 42 failed and 1 skipped) Jan 21, 2023
@fasterthanlime
Copy link
Collaborator Author

fasterthanlime commented Feb 20, 2023

Reports are now split, we're at:

  • http2: 59 passed, 34 failed, 1 skipped
  • hpack: 6 passed, 2 failed
  • generic: 44 passed

@fasterthanlime
Copy link
Collaborator Author

Since generic and hpack all pass, I'm going to edit the title of this issue to reflect just the http2 suite.

@fasterthanlime fasterthanlime changed the title h2spec tracking issue (103 passed, 42 failed and 1 skipped) h2spec-http2 tracking issue (64 passed, 30 failed) Feb 20, 2023
@github-actions github-actions bot removed the h2 label Feb 20, 2023
@fasterthanlime fasterthanlime changed the title h2spec-http2 tracking issue (64 passed, 30 failed) h2spec-http2 tracking issue (67 passed, 27 failed) Feb 20, 2023
@fasterthanlime fasterthanlime changed the title h2spec-http2 tracking issue (67 passed, 27 failed) h2spec-http2 tracking issue (72 passed, 22 failed) Oct 3, 2023
@fasterthanlime
Copy link
Collaborator Author

fasterthanlime commented Oct 3, 2023

Updated today, somehow we went from 67 passed to 72 passed, which is surprising because I don't remember specifically working on making more tests pass (I was about to)! but oh well.

The failing tests can be seen here: https://github.com/hapsoc/fluke/runs/17335784679 (until the artifact expires I guess)

@fasterthanlime fasterthanlime changed the title h2spec-http2 tracking issue (72 passed, 22 failed) h2spec-http2 tracking issue (73 passed, 21 failed) Oct 8, 2023
@fasterthanlime fasterthanlime pinned this issue Oct 17, 2023
@fasterthanlime fasterthanlime changed the title h2spec-http2 tracking issue (73 passed, 21 failed) h2spec tracking (73 passed, 21 failed) Oct 17, 2023
@fasterthanlime fasterthanlime changed the title h2spec tracking (73 passed, 21 failed) h2spec tracking (62 passed, 32 failed) Mar 12, 2024
@fasterthanlime
Copy link
Collaborator Author

The number of passing tests has regressed after refactorings, but that should be short-lived.

@fasterthanlime fasterthanlime changed the title h2spec tracking (62 passed, 32 failed) h2spec tracking (79 passed, 15 failed) Mar 15, 2024
@fasterthanlime
Copy link
Collaborator Author

The number of passing tests has regressed after refactorings, but that should be short-lived.

Yup, just bumped from 62 to 79, which is 6 better than before the refactor :)

Still some low-hanging fruits, the next big task after that is flow control, but due to the refactor, this should be nice and lock-free.

@fasterthanlime fasterthanlime changed the title h2spec tracking (79 passed, 15 failed) h2spec tracking (80 passed, 14 failed) Mar 16, 2024
@fasterthanlime
Copy link
Collaborator Author

Closing in favor of #175.

@fasterthanlime fasterthanlime unpinned this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant